Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golint fixed for modules/auth #274

Merged
merged 3 commits into from
Nov 27, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 27, 2016

No description provided.

@lunny lunny added this to the 1.0.0 milestone Nov 27, 2016
@Bwko
Copy link
Member

Bwko commented Nov 27, 2016

LGTM, except for the conflict in routers/install.go

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 27, 2016
@strk
Copy link
Member

strk commented Nov 27, 2016

LGTM, please rebase, resolve conflicts and push -f :)

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2016
@lunny lunny changed the base branch from master to 91-auto-build-version November 27, 2016 13:44
@lunny lunny changed the base branch from 91-auto-build-version to master November 27, 2016 13:44
@tboerger
Copy link
Member

LGTM

@tboerger tboerger merged commit 25b5722 into go-gitea:master Nov 27, 2016
@lunny lunny deleted the lunny/golint_modules_auth branch November 28, 2016 01:10
@lunny
Copy link
Member Author

lunny commented Nov 28, 2016

resolved #70

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants