Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal server error when deleting user with wrong password #27113

Closed
wants to merge 4 commits into from

Conversation

lng2020
Copy link
Member

@lng2020 lng2020 commented Sep 18, 2023

Reproduce procedure of this bug:
In web page settings/account, enter the wrong password and click delete to delete current user.
Before:
ksnip_20230918-111950
After:
ksnip_20230918-133241

I deleted the function IsErrUserNotExist because I don't think auth.UserSignIn will return that error. However, if there are conditions that I might missed, please correct me.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2023
@puni9869
Copy link
Member

puni9869 commented Sep 18, 2023

@lng2020
This is a known issue, some of the progress I have made here, Its a part of 1.21 milestone bug fix.
#26212
ISSUE: #26210

@lng2020
Copy link
Member Author

lng2020 commented Sep 18, 2023

@lng2020 This is a known issue, some of the progress I have made here, Its a part of 1.21 milestone bug fix. #26212 ISSUE: #26210

Thanks. Your previous efforts are really helpful, l'm closing it and reopen it after finding out the correct solution.

@lng2020 lng2020 closed this Sep 18, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants