Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlight user details link #26998

Merged
merged 12 commits into from
Oct 1, 2023
Merged

highlight user details link #26998

merged 12 commits into from
Oct 1, 2023

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Sep 10, 2023 •
edited
Loading

This PR adds a separated column in the users table for operations. The username link now redirects back to user page.

grafik

Resolves #26713 (review)

Co-authored-by: silverwind me@silverwind.io

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 10, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Sep 10, 2023
@denyskon denyskon requested a review from delvh September 10, 2023 09:53
@denyskon denyskon added this to the 1.21.0 milestone Sep 10, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Sep 10, 2023 •
edited
Loading

TBH ... IMO ... such tooltip seems redundant .......

Maybe adding a "home" icon & link is better?

@silverwind
Copy link
Member

silverwind commented Sep 11, 2023 •
edited
Loading

We should at least make user and org lists behave the same. User list name click goes to user details, org list name click goes to org page (but has a edit column). Ultimately I think we need to implement a org details page as well.

@denyskon
Copy link
Member Author

I'd do an org details page, but aren't we in feature freeze right now?

@silverwind
Copy link
Member

We should be as per recent communication but until the release/v1.21 branch is forked, we aren't in fact.

@silverwind
Copy link
Member

Maybe a home link column for both tables would be good to somewhat solve the inconsistency. I think there is still space in the table for a small "Home" column at the end with https://primer.github.io/octicons/home-16 icon.

@delvh
Copy link
Member

delvh commented Sep 13, 2023

(My original suggestion was an info icon such as octicon-info by the way)

@silverwind
Copy link
Member

silverwind commented Sep 13, 2023 •
edited
Loading

Maybe https://primer.github.io/octicons/person-16 for the user page link and https://primer.github.io/octicons/people-16 for the org page?

@lunny lunny modified the milestones: 1.21.0, 1.22.0 Sep 21, 2023
@denyskon denyskon added the backport/v1.21 This PR should be backported to Gitea 1.21 label Sep 21, 2023
@denyskon
Copy link
Member Author

grafik

I somehow tried to implement both suggestions. The username link's destination is the user page, and the user icon in the user details column leads to the user details page.

@denyskon denyskon requested review from delvh and silverwind and removed request for delvh September 21, 2023 05:33
@denyskon denyskon changed the title add tooltip to user details link highlight user details link Sep 21, 2023
@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 29, 2023
@denyskon
Copy link
Member Author

@silverwind Maybe operations would be a better word for it? I think actions might be confusing for translation. But otherwise, I think your idea is nice, thanks :)

@denyskon denyskon added the topic/ui Change the appearance of the Gitea UI label Sep 29, 2023
@silverwind silverwind mentioned this pull request Sep 29, 2023
Merged
@denyskon
Copy link
Member Author

Operations is the standard term since #22067

@silverwind
Copy link
Member

It's such a long word, but okay.

delvh
delvh reviewed Sep 29, 2023
View reviewed changes
templates/admin/org/list.tmpl Outdated Show resolved Hide resolved
templates/admin/user/list.tmpl Outdated Show resolved Hide resolved
@denyskon denyskon requested a review from delvh September 30, 2023 09:41
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 30, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2023
@lunny lunny merged commit 4ab597f into go-gitea:main Oct 1, 2023
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 1, 2023
@denyskon @silverwind @GiteaBot
highlight user details link (go-gitea#26998)
26b0d70 
This PR adds a separated column in the users table for operations. The
username link now redirects back to user page.


![grafik](https://github.com/go-gitea/gitea/assets/47871822/df8c8b30-3da6-443c-ae0f-6e3cac7dd9bb)

Resolves
go-gitea#26713 (review)

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot mentioned this pull request Oct 1, 2023
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 1, 2023
6543 pushed a commit that referenced this pull request Oct 1, 2023
@GiteaBot @denyskon @silverwind
highlight user details link (#26998) (#27376)
eea79ce 
Backport #26998 by @denyskon

This PR adds a separated column in the users table for operations. The
username link now redirects back to user page.


![grafik](https://github.com/go-gitea/gitea/assets/47871822/df8c8b30-3da6-443c-ae0f-6e3cac7dd9bb)

Resolves
#26713 (review)

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: silverwind <me@silverwind.io>
@denyskon denyskon deleted the fix/user-details-link branch November 19, 2023 13:50
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@denyskon @wxiaoguang @silverwind @delvh @lunny @GiteaBot