Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification circle (border-radius) #26794

Merged
merged 3 commits into from
Aug 29, 2023
+3 −3
Merged

Fix notification circle (border-radius) #26794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a712c07
fix
wxiaoguang Aug 29, 2023
afcaf7c
Merge branch 'main' into fix-notification-circle
wxiaoguang Aug 29, 2023
7b93e5e
Merge branch 'main' into fix-notification-circle
GiteaBot Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/* non-color variables */
--border-radius: 4px;
--border-radius-medium: 6px;
--border-radius-circle: 100%;
--border-radius-circle: 50%;
--opacity-disabled: 0.55;
--height-loading: 16rem;
--tab-size: 4;
Expand Down
4 changes: 2 additions & 2 deletions web_src/css/modules/navbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@
left: 6px;
top: -9px;
min-width: 17px;
min-height: 17px;
border-radius: var(--border-radius-circle);
height: 17px;
border-radius: 11px; /* (height + 2 * borderThickness) / 2 */
Copy link
Member

@silverwind silverwind Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the comment but value is right, matching height.

Copy link
Contributor Author

@wxiaoguang wxiaoguang Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It (the comment) is right, just rounds up.

Actually, border-radius: could be any large enough value, like 1000px

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed that you changed value as well. Well let's hope it works :)

display: flex;
align-items: center;
justify-content: center;
Expand Down