Introduce pull request commit view files page #26197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
|
CI failure looks like a template linter's bug. |
It's not a bug. It should avoid using such code layout |
puni9869
reviewed
Jul 29, 2023
| prInfo = PrepareViewPullInfo(ctx, issue) | ||
| } | ||
|
|
||
| if ctx.Written() { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. But it's still necessary because PrepareViewPullInfo is invoked.
|
Yes, it's a linter bug, but I'd also argue we should not conditionally create opening tags, there are better ways. |
|
Actually no, this is not a linter bug in this case, you are actually outputting unbalanced tags, you need the same condition that is on the opening tag for a closing tag below. |
|
I will rewrite this since #25528 merged and there are some conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a new page for view commit changes in a pull request. Before this PR, when click some commit in the commits list page of a pull request, it will jump to a commit view page. But now it will show in this pull request like GH did.
related to #25528
Before:
After:
This also avoids pull request commits have blank branches and tags listed.