Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGELOG] Drop redundant OpenID items #2608

Closed

Conversation

strk
Copy link
Member

@strk strk commented Sep 26, 2017

OpenID-2.0 login is a new feature, there's no point in mentioning
every single change included in that feature.

NOTE:
there are a lot more of these cases, just I'm not sure I've the
time to deal with them all, so this PR is a first step which I hope
can be used as an example to further simplify that file

OpenID-2.0 login is a new feature, there's no point in mentioning
every single change included in that feature.
@lunny
Copy link
Member

lunny commented Sep 26, 2017

Don't know the meaning of this PR? Since you removed all the OpenID related changelog, how users know what's happened about OpenID on v1.2?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2017
@strk
Copy link
Member Author

strk commented Sep 26, 2017 via email

@ptman
Copy link
Contributor

ptman commented Sep 28, 2017

Looks much better. A good changelog doesn't list every commit. http://keepachangelog.com/en/1.0.0/

@bkcsoft
Copy link
Member

bkcsoft commented Oct 9, 2017

Why do we even have the changelog entries for RCs?

@strk
Copy link
Member Author

strk commented Oct 10, 2017 via email

@bkcsoft
Copy link
Member

bkcsoft commented Oct 10, 2017

I agree that since this is for a single release we don't have to list all the OpenID PRs separately. Maybe have the other PR-numbers on the line that's left though?

@lafriks
Copy link
Member

lafriks commented Oct 10, 2017

Yes but the problem is we generate it automatically. Any ideas how to mark PR to group them together in on changelog?

@daviian
Copy link
Member

daviian commented Oct 10, 2017

I think that if we manage to stick to a short release cycle, we don't have to summarize the PRs as there won't be that much anyway...
However we have to pull ourselfs up on making small and early releases.

@bkcsoft
Copy link
Member

bkcsoft commented Oct 10, 2017

Biggest issue I've seen with making releases is that it's cumbersome. Just to give an indication:

  1. Generate changelog from git log --oneline v${oldVer}.. >> CHANGELOG.md & edit
  2. commit and PR (in both master and release-branch), wait for merge
  3. (optionally branch release-branch)
  4. tag v${newVer} from release-branch
  5. Make and upload blogpost, wait for PR merge

All in all takes about a day if you're lucky

It would be better if Changelog was auto-generated, so we could skip the PR-stage to that and just commit directly to master & rel-branch. But blogpost still takes time.

And then hopefully the build-system works as intended ;)

@strk
Copy link
Member Author

strk commented Oct 11, 2017 via email

@bkcsoft
Copy link
Member

bkcsoft commented Oct 15, 2017

There was/is #505, and yes that would not need an entry for fixes in the same release.

@lunny
Copy link
Member

lunny commented Oct 15, 2017

@strk I think we should discuss these on a release notes PR but not a new PR. And since v1.2.0 has been released. I think we can close this one and be careful when we release v1.3.0

@lunny lunny closed this Oct 15, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants