Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize admin settings sidebar panel #26030

Merged
merged 22 commits into from
Jul 24, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Jul 21, 2023

This PR reorganize and categorize the admin settings sidebar panel into groups:

  • User Accounts, User Emails, Organizations, Authentication Sources -> Identity & Access
  • Repositories, Packages -> Code Assets
  • Webhooks, Applications -> Integrations

Before:

Screen Shot 2023-07-21 at 10 30 28

After:

all configurable settings enabled (package, oauth, webhook)

Screen Shot 2023-07-21 at 10 27 30

all configurable settings disabled (package, oauth, webhook)

Screen Shot 2023-07-21 at 10 25 19

only oauth enabled

Screen Shot 2023-07-21 at 10 26 23

only webhook enabled

Screen Shot 2023-07-21 at 10 26 55

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2023
@wxiaoguang
Copy link
Contributor

"Organization Structure" seems pretty longer than others .....

@HesterG
Copy link
Contributor Author

HesterG commented Jul 21, 2023

"Organization Structure" seems pretty longer than others .....

Is there a suggestion for this name? It is actually almost the same length as "Authentication Sources"

@harryzcy
Copy link
Contributor

@HesterG Maybe call it "Identity & Access"? just a little bit shorter.

@HesterG
Copy link
Contributor Author

HesterG commented Jul 21, 2023

@HesterG Maybe call it "Identity & Access"? just a little bit shorter.

Sounds OK. I will wait for some other suggestion, if there is no incoming suggestion, i will go with this one.

@HesterG
Copy link
Contributor Author

HesterG commented Jul 21, 2023

Updated "Organization Structure" to "Identity & Access"

options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
templates/admin/navbar.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2023
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 21, 2023
@lunny lunny added this to the 1.21.0 milestone Jul 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 21, 2023
@puni9869
Copy link
Member

puni9869 commented Jul 21, 2023

Not a blocker, could you arrange them alphabetically [the inner list items].

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 21, 2023
@HesterG
Copy link
Contributor Author

HesterG commented Jul 22, 2023

Not a blocker, could you arrange them alphabetically [the inner list items].

Updated c561d3c

@lunny lunny merged commit 24c3bb9 into go-gitea:main Jul 24, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 24, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 25, 2023
* giteaofficial/main: (23 commits)
  Avoid writing config file if not installed (go-gitea#26107)
  Implement auto-cancellation of concurrent jobs if the event is push (go-gitea#25716)
  [skip ci] Updated translations via Crowdin
  doc guide the user to create the appropriate level runner (go-gitea#26091)
  Fix handling of Debian files with trailing slash (go-gitea#26087)
  fix Missing 404 swagger response docs for /admin/users/{username} (go-gitea#26086)
  Allow the use of alternative net.Listener implementations by downstreams (go-gitea#25855)
  Add missing default value for some Bool cli flags (go-gitea#26082)
  Reduce unnecessary DB queries for Actions tasks (go-gitea#25199)
  Use stderr as fallback if the log file can't be opened (go-gitea#26074)
  Make organization redirect warning more clear (go-gitea#26077)
  Replace gogs/cron with go-co-op/gocron (go-gitea#25977)
  Remove `db.DefaultContext` in `routers/` and `cmd/` (go-gitea#26076)
  Categorize admin settings sidebar panel (go-gitea#26030)
  [skip ci] Updated translations via Crowdin
  Fix duplicated url prefix on issue context menu (go-gitea#26066)
  Add context parameter to some database functions (go-gitea#26055)
  Fix branch list auth (go-gitea#26041)
  Fix the truncate and alignment problem for some admin tables (go-gitea#26042)
  Update secrets.en-us.md (go-gitea#26057)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants