Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar fixes #25402

Merged
merged 6 commits into from
Jun 24, 2023
Merged

Navbar fixes #25402

merged 6 commits into from
Jun 24, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 20, 2023 •
edited
Loading

Fixes: #25444

Followup for some regressions from #25343. Before and after:

Screenshot 2023-06-21 at 00 25 20 Screenshot 2023-06-21 at 00 25 32

Fixes mobile button background and margins:

Screenshot 2023-06-21 at 00 39 58

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@silverwind silverwind added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 20, 2023
@silverwind silverwind mentioned this pull request Jun 22, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2023
@silverwind
Copy link
Member Author

silverwind commented Jun 23, 2023 •
edited
Loading

@wxiaoguang care for a review? I realize #navbar .dropdown .item is not a ideal solution, but I was having a hard time because the .menu .item.dropdown .item nesting, so this is the "simple but ugly" solution to that problem.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@lunny lunny enabled auto-merge (squash) June 24, 2023 03:56
@lunny lunny merged commit be47015 into go-gitea:main Jun 24, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@silverwind silverwind deleted the navfixes branch June 25, 2023 22:19
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Navbar menu regression
4 participants
@silverwind @lunny @wxiaoguang @GiteaBot