Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide limited users if viewed by anonymous ghost #25214

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Hide limited users if viewed by anonymous ghost #25214

merged 3 commits into from
Jun 13, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jun 12, 2023

The ghost user leads to inclusion of limited users/orgs in BuildCanSeeUserCondition.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2023
@techknowlogick techknowlogick added the backport/v1.20 This PR should be backported to Gitea 1.20 label Jun 12, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
@lunny lunny merged commit 2126f71 into go-gitea:main Jun 13, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 13, 2023
@GiteaBot GiteaBot mentioned this pull request Jun 13, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 13, 2023
@KN4CK3R @GiteaBot
Hide limited users if viewed by anonymous ghost (go-gitea#25214)
facffd9 
The ghost user leads to inclusion of limited users/orgs in
`BuildCanSeeUserCondition`.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 13, 2023
lunny pushed a commit that referenced this pull request Jun 13, 2023
@GiteaBot @KN4CK3R
Hide limited users if viewed by anonymous ghost (#25214) (#25220)
f64f549 
Backport #25214 by @KN4CK3R

The ghost user leads to inclusion of limited users/orgs in
`BuildCanSeeUserCondition`.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@KN4CK3R KN4CK3R deleted the fix-container-catalog-limited branch June 13, 2023 06:01
@KN4CK3R KN4CK3R added outdated/backport/v1.19 This PR should be backported to Gitea 1.19 and removed backport/done All backports for this PR have been created outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Jun 13, 2023
@GiteaBot GiteaBot mentioned this pull request Jun 13, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 13, 2023
@KN4CK3R @GiteaBot
Hide limited users if viewed by anonymous ghost (go-gitea#25214)
b6edcb3 
The ghost user leads to inclusion of limited users/orgs in
`BuildCanSeeUserCondition`.
@GiteaBot GiteaBot mentioned this pull request Jun 13, 2023
Closed
silverwind pushed a commit that referenced this pull request Jun 13, 2023
@GiteaBot @KN4CK3R
Hide limited users if viewed by anonymous ghost (#25214) (#25224)
a9ebf91 
Backport #25214 by @KN4CK3R

The ghost user leads to inclusion of limited users/orgs in
`BuildCanSeeUserCondition`.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@KN4CK3R KN4CK3R added the backport/done All backports for this PR have been created label Jun 13, 2023
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 23, 2023
@GiteaBot @earl-warren
Hide limited users if viewed by anonymous ghost (go-gitea#25214) (go-…
38e5589 
…gitea#25224)

Backport go-gitea#25214 by @KN4CK3R

The ghost user leads to inclusion of limited users/orgs in
`BuildCanSeeUserCondition`.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
(cherry picked from commit a9ebf91)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/packages type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@KN4CK3R @silverwind @delvh @lunny @techknowlogick @GiteaBot