Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various avatar dimensions #24701

Merged
merged 10 commits into from
May 14, 2023
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 13, 2023

Clean up a few cases where avatar dimensions were overwritten via CSS, which were no longer needed or were possible to set via HTML width.

Also included are two small fixes:

  • Fix one more case of incorrect avatar offset on review timeline
  • Vertically center avatars in review sidebar

There is more to be done here, but some of the work depends on Fomantic comment module removal, or in the case of org member lists, a refactor of the avatarlink template to accept a size.

image image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2023
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 13, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 13, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 14, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2023
@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2023
@silverwind silverwind marked this pull request as draft May 14, 2023 08:21
@silverwind
Copy link
Member Author

Now that the comment module is gone, I can clean up a few more here, putting on WIP until then.

@silverwind
Copy link
Member Author

silverwind commented May 14, 2023

More avatar and related fixes done in 5d182fa. Also fixed one long-standing fomantic bug via :has selector where the bottom border radius on these collapsed boxes was incorrect:

Screenshot 2023-05-14 at 13 44 42

@silverwind silverwind marked this pull request as ready for review May 14, 2023 11:45
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2023
@silverwind silverwind enabled auto-merge (squash) May 14, 2023 11:55
@silverwind silverwind merged commit b92c142 into go-gitea:main May 14, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 14, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2023
@silverwind silverwind deleted the ava-cleanup branch May 14, 2023 18:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 15, 2023
* upstream/main: (30 commits)
  Don't filter action runs based on state (go-gitea#24711)
  Add Go package registry (go-gitea#24687)
  Fix flash of unstyled content in action view page (go-gitea#24712)
  Clean up various avatar dimensions (go-gitea#24701)
  Remove the parallelizing when loading repo for dashboard (go-gitea#24705)
  Optimize actions list by removing an unnecessary `git` call (go-gitea#24710)
  Update cron-translations.yml (go-gitea#24708)
  Fix run list broken when trigger user deleted (go-gitea#24706)
  Remove Fomantic comment module (go-gitea#24703)
  Update to Alpine 3.18 (go-gitea#24700)
  fix minio storage iterator path (go-gitea#24691)
  Add status indicator on main home screen for each repo (go-gitea#24638)
  Add test for api team orgnization (go-gitea#24699)
  Improve button-ghost, remove tertiary button (go-gitea#24692)
  Add icon support for safari (go-gitea#24697)
  Improve avatar uploading / resizing / compressing, remove Fomantic card module (go-gitea#24653)
  Fix docs documenting invalid `@every` for `OLDER_THAN` cron settings (go-gitea#24695)
  Fix `organization` field being `null` in `GET /api/v1/teams/{id}` (go-gitea#24694)
  Use standard HTTP library to serve files (go-gitea#24693)
  Add `eslint-plugin-eslint-comments` (go-gitea#24690)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants