Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use auto-updating, natively hoverable, localized time elements #23988

Merged
merged 59 commits into from
Apr 10, 2023
Merged

Use auto-updating, natively hoverable, localized time elements #23988

merged 59 commits into from
Apr 10, 2023

Commits on Apr 7, 2023

  1. Use auto-updating, natively hoverable, localized time elements 

    - Added GitHub’s `relative-time` element
- Converted all formatted timestamps to use this element
- No more flashes of unstyled content around time elements
- These elements have native tooltips that show the full timestamp and are localized using the HTML’s `lang` property
- Relative (e.g. the activities in the dashboard) and duration (e.g. server uptime in the admin page) time elements are auto-updated to keep up with the current time without refreshing the page
- Deleted code that is not needed anymore, such as `formatting.js` and simplified `since.go`

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
    @yardenshoham
    yardenshoham committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    506d1b3 View commit details
    Browse the repository at this point in the history

  2. Use shared templates

    @yardenshoham
    yardenshoham committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    baee7bd View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    630767a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    c5ac2d2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    fcb90d3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    a58c19f View commit details
    Browse the repository at this point in the history

  5. Use tense="path" to avoid the unlocalized on

    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f9c0e98 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    687e973 View commit details
    Browse the repository at this point in the history

  7. Remove test file

    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    359706e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    bdcc448 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f35ad55 View commit details
    Browse the repository at this point in the history

  10. Use a better format for javascript parsing 

    Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
    @yardenshoham @wxiaoguang
    yardenshoham and wxiaoguang committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    4801743 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    5d282d1 View commit details
    Browse the repository at this point in the history

  12. Fix tests

    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    113aaf7 View commit details
    Browse the repository at this point in the history

  13. Drop tense=past to support future dates 

    Just remove `on`
    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    fc6b5c3 View commit details
    Browse the repository at this point in the history

  14. Update comment

    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f2838d9 View commit details
    Browse the repository at this point in the history

  15. Localize on

    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    def9978 View commit details
    Browse the repository at this point in the history

  16. Undo unnecessary changes

    @yardenshoham
    yardenshoham committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    0c313f6 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    617435f View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. Fix missed undo of find-and-replace 

    Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
    @yardenshoham @wxiaoguang
    yardenshoham and wxiaoguang committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    fc81d1b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    29f385e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    4c238b2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    05d4c58 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    85385cb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    217c36e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    89abdd3 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8c18c51 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8423fba View commit details
    Browse the repository at this point in the history

  10. Use RFC3339

    @yardenshoham
    yardenshoham committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    faee6f0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into time

    @yardenshoham
    yardenshoham committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    49b26a4 View commit details
    Browse the repository at this point in the history

  12. Allow interactive tooltips, disable the title

    @yardenshoham
    yardenshoham committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    7aaee69 View commit details
    Browse the repository at this point in the history

  13. Revert "Allow interactive tooltips, disable the title" 

    This reverts commit 7aaee69.
    @silverwind
    silverwind committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    98e89a0 View commit details
    Browse the repository at this point in the history

  14. add tooltip swap and add it to mutation observer

    @silverwind
    silverwind committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    1b34f56 View commit details
    Browse the repository at this point in the history

  15. tweak comment

    @silverwind
    silverwind committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    e72bdf7 View commit details
    Browse the repository at this point in the history

  16. filter for .time-since

    @silverwind
    silverwind committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8976d33 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. general title => tippy tooltip switching

    @wxiaoguang
    wxiaoguang committed Apr 10, 2023
    4 Configuration menu
    Copy the full SHA
    da185ae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    80becbc View commit details
    Browse the repository at this point in the history

  3. send UTC only to browsers

    @silverwind
    silverwind committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    722967b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    67b0aa9 View commit details
    Browse the repository at this point in the history

  5. handle newly added tooltip element itself

    @wxiaoguang
    wxiaoguang committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d6e28d6 View commit details
    Browse the repository at this point in the history

  6. Update web_src/js/modules/tippy.js 

    Co-authored-by: silverwind <me@silverwind.io>
    @wxiaoguang @silverwind
    wxiaoguang and silverwind authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    ec57cdd View commit details
    Browse the repository at this point in the history

  7. explain why the title attribute is kept

    @wxiaoguang
    wxiaoguang committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    db92c16 View commit details
    Browse the repository at this point in the history

  8. Update templates/admin/org/list.tmpl 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    89b0f02 View commit details
    Browse the repository at this point in the history

  9. Update templates/package/shared/cleanup_rules/preview.tmpl 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    8969ba8 View commit details
    Browse the repository at this point in the history

  10. Update templates/admin/user/list.tmpl 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    617add3 View commit details
    Browse the repository at this point in the history

  11. Update templates/admin/packages/list.tmpl 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d651534 View commit details
    Browse the repository at this point in the history

  12. Update templates/admin/user/list.tmpl 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e03f316 View commit details
    Browse the repository at this point in the history

  13. Update templates/admin/repo/list.tmpl 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    17d883f View commit details
    Browse the repository at this point in the history

  14. Drop unnecessary title from process-row

    @yardenshoham
    yardenshoham committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    12cecdf View commit details
    Browse the repository at this point in the history

  15. Update modules/timeutil/timestamp.go 

    Co-authored-by: delvh <dev.lh@web.de>
    @yardenshoham @delvh
    yardenshoham and delvh authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    fde6c38 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    3cd6cd8 View commit details
    Browse the repository at this point in the history

  17. Found more dates

    @yardenshoham
    yardenshoham committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    460fe71 View commit details
    Browse the repository at this point in the history

  18. Localize notice

    @yardenshoham
    yardenshoham committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    b7064ed View commit details
    Browse the repository at this point in the history

  19. add on_date

    @silverwind
    silverwind committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e81c5cd View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    838b867 View commit details
    Browse the repository at this point in the history

  21. take pending mutations when disconnect

    @wxiaoguang
    wxiaoguang committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    113e2d5 View commit details
    Browse the repository at this point in the history

  22. update comment, tweak interactiveBorder to prevent some double tooltips

    @silverwind
    silverwind committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    7e27112 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    16cde5e View commit details
    Browse the repository at this point in the history

  24. Merge branch 'main' into time

    @yardenshoham
    yardenshoham authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    c706cab View commit details
    Browse the repository at this point in the history