-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap most paragraphs to 80 columns #2396
Conversation
Reduces patches size and makes them more readable
LGTM. And Agreed |
Github offer rendered diff that display diff of the rendered mardown that is more strict on what is changed. For example for this PR has Otherwise LGTM. |
@@ -19,7 +19,16 @@ | |||
|
|||
## Purpose | |||
|
|||
The goal of this project is to make the easiest, fastest, and most painless way of setting up a self-hosted Git service. Using Go, this can be done with an independent binary distribution across **all platforms** which Go supports, including Linux, macOS, and Windows on x86, amd64, ARM and PowerPC architectures. Want to try it before doing anything else? Do it [with the online demo](https://try.gitea.io/)! This project has been [forked](https://blog.gitea.io/2016/12/welcome-to-gitea/) from [Gogs](https://gogs.io). | |||
The goal of this project is to make the easiest, fastest, and most |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have discussed this many times. I don't think this is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lunny Any reason why we should not do it? From my point of view we allow people to review using git diff
and in GitHub nothing would change.
On Sun, Aug 27, 2017 at 03:49:05PM -0700, Antoine GIRARD wrote:
Github offer rendered diff that display diff of the rendered mardown that is more strict on what is changed.
I don't think it's good to restrict users/contributors options
to "use GitHub"... offline `git diff` and email notifications
@lunny there are 2 LGTM give by maintainer, saying "no" should
be justified by an high risk of project degradation, which is
not the case here. If you think 2 approvals are not enough
then please send a proposal to change project management policy.
|
@strk Our policy is no need changed. A PR should have at least 2 LGTM for mergable. But that don't mean 2 LGTM PRs have to be merged. Even if there are 2 LGTM, if someone has different opinion, it should be discussed more. |
on x86, amd64, ARM and PowerPC architectures. | ||
Want to try it before doing anything else? | ||
Do it [with the online demo](https://try.gitea.io/)! | ||
This project has been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the below 3 lines will be very strange after rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not :) https://github.com/strk/gitea/tree/wrap80#purpose
This is a story between |
80 characters *before* rendering
I believe markdown renders all on the same line unless an empty line
is encountered
|
Reduces patches size and makes them more readable
I think it should be done for all text files, only not
doing it yet here because I know of at least another
open PR that modifies CONTRIBUTING.md (and is hard to
review due to the loooong single-line being changed)
See https://github.com/go-gitea/gitea/pull/2394/files