Fix intermittent CI failure in EmptyQueue #23753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering of the final token causing a close of the queue in this test may be out of sync due to concurrency. Instead just use ensure that the queue is closed when everything expected is done. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/testing
outdated/backport/v1.19
|
CI fail is related |
GiteaBot
added
the
lgtm/need 2
KN4CK3R
reviewed
Mar 28, 2023
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
|
Sorry about the race - I forgot that there were two things that were simultaneously writing to that map so assumed it didn't need a lock |
|
Still failing it seems. |
pull-request-size
bot
added
the
size/M
|
#24419 had disabled two queue tests on CI, if they are stable again, remove the disablement. |
|
The old queue code is unmaintainable now, I have started the rewriting. I believe the queue package can be hugely simplified. |
…ure-in-EmptyQueue
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
The problem in this PR was simple; the atomic int needed to be defined outside of the handler and the count needs to be pushed to the done channel outside of the lock. @wxiaoguang the queue code complexity is a natural result of the requirements. You're just going to create more bugs and reiterate errors. |
silverwind
approved these changes
May 3, 2023
GiteaBot
added
lgtm/need 1
|
Added issue references to OP. |
techknowlogick
approved these changes
May 3, 2023
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.19. @zeripath, please send one manually. 🍵 |
GiteaBot
added
backport/manual
Nope, I never created more bugs. I will finish the rewriting soon. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2023
* upstream/main: (65 commits) Changelog for 1.19.3 (go-gitea#24495) (go-gitea#24506) Use Actions for DB & E2E tests (go-gitea#24494) Fix intermittent CI failure in EmptyQueue (go-gitea#23753) Prevent a user with a different email from accepting the team invite (go-gitea#24491) Fix incorrect webhook time and use relative-time to display it (go-gitea#24477) Make Issue/PR/projects more compact, misc CSS tweaks (go-gitea#24459) Implement Cargo HTTP index (go-gitea#24452) Clean up polluted styles and remove dead CSS code (go-gitea#24497) Improve pull request merge box when pull request merged and branch deleted. (go-gitea#24397) Fix EasyMDE toolbar (go-gitea#24489) Enhance stylelint rule config, remove dead CSS (go-gitea#24472) Fix api error message if fork exists (go-gitea#24487) Add ntlm authentication support for mail (go-gitea#23811) Fix test delivery button in repo webhook settings page (go-gitea#24478) Add Debian package registry (go-gitea#24426) Enable whitespace rendering on selection in Monaco (go-gitea#24444) Replace `N/A` with `-` everywhere (go-gitea#24474) Fix invite display (go-gitea#24447) [skip ci] Updated translations via Crowdin replace PR docker dry run in drone with Actions (go-gitea#24475) ... # Conflicts: # templates/base/footer_content.tmpl
lunny
removed
the
outdated/backport/v1.19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of the final token causing a close of the queue in this test may be out of sync due to concurrency. Instead just use ensure that the queue is closed when everything expected is done.
Fixes: #23608
Fixes: #23977