Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new issue/pull request btn margin when it is next to sort #23647

Merged
merged 9 commits into from
Mar 23, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Mar 23, 2023

Close #23627

Added margin left to the button when it is next to the svg, which has a margin-right of -0.5rem

And here it might be better if white-space: nowrap; is added because otherwise it might look like below on pull requests page on smaller screen

截屏2023-03-23 09 57 41

After:
截屏2023-03-23 10 08 27

Pull Request on smaller screen
截屏2023-03-23 10 25 16

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Mar 23, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 23, 2023
@@ -88,7 +88,7 @@
<div class="column right aligned gt-df gt-ac gt-je">
<!-- Sort -->
<div class="ui dropdown type jump item">
<span class="text">
<span class="text sort-dropdown">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 23, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 23, 2023 17:42
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 23, 2023
@techknowlogick techknowlogick merged commit 9cefb7b into go-gitea:main Mar 23, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 24, 2023
* upstream/main:
  Fix incorrect `HookEventType` of pull request review comments (go-gitea#23650)
  [skip ci] Updated translations via Crowdin
  Fix codeblocks in the cheat sheet (go-gitea#23664)
  Drop migration for ForeignReference (go-gitea#23605)
  Fix new issue/pull request btn margin when it is next to sort (go-gitea#23647)
  A tool to help to backport locales, changes source strings to fix other broken translations (go-gitea#23633)
  Fix incorrect `show-modal` and `show-panel` class (go-gitea#23660)
  Restructure documentation. Now the documentation has installation, administration, usage, development, contributing the 5 main parts (go-gitea#23629)
  Check LFS/Packages settings in dump and doctor command (go-gitea#23631)
  Use a general approach to show tooltip, fix temporary tooltip bug (go-gitea#23574)
  Improve workflow event triggers (go-gitea#23613)
  Improve `<SvgIcon>` to make it output `svg` node and optimize performance (go-gitea#23570)
@HesterG HesterG deleted the fix-new-btn branch April 10, 2023 02:28
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect location of New Issue button in user issue dashboard
6 participants