Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct captured group range when parsing cross-reference #22672

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Use correct captured group range when parsing cross-reference #22672

merged 4 commits into from
Jan 31, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fixes #22666 (Replace #22668)

@wxiaoguang wxiaoguang mentioned this pull request Jan 31, 2023
Closed
@lunny
Copy link
Member

lunny commented Jan 31, 2023

Could we add a test for that space situation?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2023
@wxiaoguang
Copy link
Contributor Author

BUT, there was already one:

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2023
@lunny lunny added the type/bug label Jan 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 31, 2023
@KN4CK3R KN4CK3R merged commit 36dc118 into go-gitea:main Jan 31, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 31, 2023
@wxiaoguang wxiaoguang deleted the fix-cross-ref branch January 31, 2023 11:00
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@wolfogre wolfogre wolfogre approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-repo commit reference gobbles up whitespace
7 participants
@wxiaoguang @lunny @KN4CK3R @wolfogre @yardenshoham @GiteaBot @zeripath