-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve explore relevancy note #22421
improve explore relevancy note #22421
Conversation
requesting review from @Gusted |
@@ -30,7 +30,7 @@ | |||
</div> | |||
</form> | |||
{{if .OnlyShowRelevant}} | |||
<div class="ui blue attached message explore-relevancy-note"> | |||
<div class="ui message explore-relevancy-note"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the class is not removed since the ui.explore-relevancy-note
was deleted in _explore.less ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I thought it could be useful if a theme wanted to explicitly change the styling on it independently. I'm not particularly attached to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, it is no longer attached so it does look fine.
I made the changes as proposed in the comment that I copied from Codeberg. I think it would look awkward being detached and also the same width as the search bar. When it was attached, @Gaarco made a great point about the borders being slightly misaligned and the rounded corners making it look weird if you pixel-peep. If you prefer it attached to the search box, perhaps we can adjust the styling to eliminate these issues instead. |
* upstream/main: Continue GCing other repos on error in one repo (go-gitea#22422) improve explore relevancy note (go-gitea#22421) fix: don't replace err variable in nested check (go-gitea#22416) Add more packages to denylist (go-gitea#22412) fix wrong theme class when logged out if default theme is changed (go-gitea#22408) Update golang deps (go-gitea#22410)
makes the explore relevancy note much prettier on most themes