Fix internal requests when gitea listens to unix socket or only external IP #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
force-pushed
the
fix_ssh_sockets
branch
2 times, most recently
from
04a6df3
to
03fd058
Compare
silverwind
reviewed
Jul 30, 2017
modules/private/branch.go
Outdated
| resp, err := newRequest(reqURL, "GET").SetTLSClientConfig(&tls.Config{ | ||
| InsecureSkipVerify: true, | ||
| }).Response() | ||
| resp, err := newInternalReqest(reqURL, "GET").Response() |
|
LGTM, but integration test is better. |
tboerger
added
the
lgtm/need 1
|
Can not create integration test for this as it requires external ssh server |
|
LGTM |
tboerger
added
lgtm/done
sapk
approved these changes
Aug 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2232