Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting HTTP headers after write #21833

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Fix setting HTTP headers after write #21833

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2217f0b
Fix setting headers after write.
KN4CK3R Nov 16, 2022
101fe41
lint
KN4CK3R Nov 16, 2022
9a2f7cd
Refactor SetServeHeaders.
KN4CK3R Nov 16, 2022
5bf8a33
Escape quotes.
KN4CK3R Nov 17, 2022
eb0b823
Merge branch 'main' of https://github.com/go-gitea/gitea into fix-wri…
KN4CK3R Nov 17, 2022
5dd579a
Escape backslashes.
KN4CK3R Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/context/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,9 @@ func (ctx *Context) plainTextInternal(skip, status int, bs []byte) {
if statusPrefix == 4 || statusPrefix == 5 {
log.Log(skip, log.TRACE, "plainTextInternal (status=%d): %s", status, string(bs))
}
ctx.Resp.WriteHeader(status)
ctx.Resp.Header().Set("Content-Type", "text/plain;charset=utf-8")
ctx.Resp.Header().Set("X-Content-Type-Options", "nosniff")
ctx.Resp.WriteHeader(status)
if _, err := ctx.Resp.Write(bs); err != nil {
log.ErrorWithSkip(skip, "plainTextInternal (status=%d): write bytes failed: %v", status, err)
}
Expand All @@ -349,7 +349,7 @@ func (ctx *Context) RespHeader() http.Header {
func (ctx *Context) SetServeHeaders(filename string) {
ctx.Resp.Header().Set("Content-Description", "File Transfer")
Copy link
Member Author

@KN4CK3R KN4CK3R Nov 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header Content-Description does not exists. Looks like the whole block was copied from https://stackoverflow.com/questions/8485886/force-file-download-with-php-using-header

ctx.Resp.Header().Set("Content-Type", "application/octet-stream")
ctx.Resp.Header().Set("Content-Disposition", "attachment; filename="+filename)
ctx.Resp.Header().Set("Content-Disposition", fmt.Sprintf(`attachment; filename="%s"; filename*=UTF-8''%s`, filename, url.PathEscape(filename)))
KN4CK3R marked this conversation as resolved.
Show resolved Hide resolved
ctx.Resp.Header().Set("Content-Transfer-Encoding", "binary")
Copy link
Member Author

@KN4CK3R KN4CK3R Nov 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header Content-Transfer-Encoding is only used in emails.

ctx.Resp.Header().Set("Expires", "0")
ctx.Resp.Header().Set("Cache-Control", "must-revalidate")
Expand Down
1 change: 0 additions & 1 deletion routers/web/feed/profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ func showUserFeed(ctx *context.Context, formatType string) {

// writeFeed write a feeds.Feed as atom or rss to ctx.Resp
func writeFeed(ctx *context.Context, feed *feeds.Feed, formatType string) {
ctx.Resp.WriteHeader(http.StatusOK)
KN4CK3R marked this conversation as resolved.
Show resolved Hide resolved
if formatType == "atom" {
ctx.Resp.Header().Set("Content-Type", "application/atom+xml;charset=utf-8")
if err := feed.WriteAtom(ctx.Resp); err != nil {
Expand Down