Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile update for non-local users #2178

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 18, 2017

Remove required field from UpdateProfileForm as there is check later not to update Name if it is empty. Fixes #2176

@lafriks lafriks added this to the 1.2.0 milestone Jul 18, 2017
@lunny
Copy link
Member

lunny commented Jul 18, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 18, 2017
@lafriks lafriks force-pushed the fix/non_local_profile_update branch from 83eca08 to ee05fc8 Compare July 18, 2017 13:57
@Bwko
Copy link
Member

Bwko commented Jul 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 18, 2017
@lunny lunny merged commit 3702dac into go-gitea:master Jul 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP users cannot edit profile anymore: "Name cannot be empty"
4 participants