update goth to add pkce support

[techknowlogick]

fix #21376

credit to @zeripath for the PR to goth

[zeripath]

I think we need to add a few more things to our openconnectid to hook it in

[mhkarimi1383]

CI is failing...
from the logs:

Please run 'make tidy' and commit the result

[Gusted]

CI failure still related, likely due to the changes in assets/go-licenses.json

[mhkarimi1383]

Any update on this?

[lunny]

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

[silverwind]

Might want to update to v1.75.1.

[zeripath]

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

[mhkarimi1383]

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

If you can give me a test docker image I can test it for git.karimi.dev (I have LogTo and gitea)

[wolfogre]

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

If you can give me a test docker image I can test it for git.karimi.dev (I have LogTo and gitea)

@mhkarimi1383

You could try this image docker.io/wolfogre/gitea-dev:pr21426, please note that it's for testing only.

[mhkarimi1383]

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

If you can give me a test docker image I can test it for git.karimi.dev (I have LogTo and gitea)

@mhkarimi1383

You could try this image docker.io/wolfogre/gitea-dev:pr21426, please note that it's for testing only.

@wolfogre

the problem persist

gitea       | 2022/11/09 21:08:56 [636ba668] router: completed GET /user/oauth2/Logto for 51.89.252.106:0, 307 Temporary Redirect in 3.6ms @ auth/oauth.go:801(auth.SignInOAuth)
gitea       | 2022/11/09 21:08:56 ...rs/web/auth/oauth.go:860:SignInOAuthCallback() [I] [636ba668-2] Failed OAuth callback: (invalid_request) Authorization Server policy requires PKCE to be used for this request
gitea       | 2022/11/09 21:08:56 [636ba668-2] router: completed GET /user/oauth2/Logto/callback?error=invalid_request&error_description=Authorization%20Server%20policy%20requires%20PKCE%20to%20be%20used%20for%20this%20request&state=39f9aeb6-70d4-4724-aa4b-7674620d762c&iss=https%3A%2F%2Fauth.karimi.dev%2Foidc for 51.89.252.106:0, 303 See Other in 2.6ms @ auth/oauth.go:835(auth.SignInOAuthCallback)
gitea       | 2022/11/09 21:08:57 [636ba669] router: completed GET /user/login for 51.89.252.106:0, 200 OK in 4.5ms @ auth/auth.go:152(auth.SignIn)

[mhkarimi1383]

Any updates?

[zeripath]

conflicts resolved

[zeripath]

Any updates?

I haven't had any time to do the work to add the PKCE code in.

[lunny]

conflicts resolved

Looks like it's a blank PR now

[mhkarimi1383]

But issue for PKCE Persist

[jolheiser]

This (module update) has been superseded by #22410

Note that, as @zeripath said, more work needs to be done for the actual PKCE part, but that is for another PR as I understand it.

(If that is not the case, feel free to re-open and add commits)