Disabled registration notification e-mail in ldap + reverse proxy mode

[pboguslawski]

Disabled registration notification e-mail in ldap + reverse proxy mode to avoid
spamming user with invalid instructions (such accounts are created by admin
in LDAP not during self registration and no gitea passwords are used for auth).

Related: #18601
Author-Change-Id: IB#1122610

[wxiaoguang]

It looks good to me. According to the comment: SendRegisterNotifyMail triggers a notify e-mail by admin created a account., then the SendRegisterNotifyMail shouldn't be called for accounts created by other methods. The email only contains links for "login" and "forget password", which doesn't make sense in other cases.

And beside the LDAP and ReverseProxy mode, there seems to be more calls to it (pam/sspi/smtp), should these calls also be removed together?

[pboguslawski]

And beside the LDAP and ReverseProxy mode, there seems to be more calls to it (pam/sspi/smtp), should these calls also be removed together?

This mod was checked with reverse proxy+ldap scenario only and we don't use/test other cases. Feel free to adjust other auth backends also if appropriate in other PRs.

[wxiaoguang]

Replaced by Do not send "registration success email" for external auth sources #24632