Replace ServeStream with ServeContent
#20903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
the
type/refactoring
|
I guess the question is if we think this is a significant slowdown because of this? A possibility might be to use ServeFile to somehow avoid it if necessary. |
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Aug 21, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 21, 2022
GiteaBot
added
lgtm/done
Co-authored-by: delvh <dev.lh@web.de>
Yes. The best solution is if https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/net/http/fs.go;drc=8d57f4dcef5d69a0a3f807afaa9625018569010b;bpv=1;bpt=1;l=221 would be exported. Then we could simply pass the content size and the seek would just occur if it is needed because of the http range header. It's just unnecessary work at the moment. |
|
I wonder if we can instead refactor to use ServeFile instead but I'm not certain how worth it it would be |
Codecov Report
@@ Coverage Diff @@
## main #20903 +/- ##
=======================================
Coverage ? 46.84%
=======================================
Files ? 993
Lines ? 136758
Branches ? 0
=======================================
Hits ? 64059
Misses ? 64836
Partials ? 7863
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Aug 22, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 26, 2022
* upstream/main: Add whitespace removal inside template curly brackes (go-gitea#20853) Only show relevant repositories on explore page (go-gitea#19361) Replace `ServeStream` with `ServeContent` (go-gitea#20903) Update JS dependencies (go-gitea#20950) chore: remove broken gitea-format-imports (go-gitea#20952)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
* Replace ServeStream with ServeContent. * Update modules/timeutil/timestamp.go Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 4, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR from Discord
Replace
ServeStreamwithServeContentwhich enabled HTTP range support for downloads. Only the package registry and the repo archiver useServeStream.A possible downside may be that
http.ServeContentuses theSeekmethod to get the length of the stream. Sadly there is no way to pass the size as parameter even if we know it.