Fix the admin mailer config display #20633
Merged
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
skip-changelog
|
lemme try this out.. |
GiteaBot
added
the
lgtm/need 2
There was a problem hiding this comment.
I'd approve (again) if I had rights..
I built Gitea with this patch and it fixes the issue for me, admin page is back and I was able to send a "test email".
Thanks for a lighning-fast fix! @wxiaoguang
techknowlogick
approved these changes
Aug 2, 2022
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Aug 2, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 3, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Use `strings.Cut` for GIT_PROTOCOL value (go-gitea#20638) Fix the admin mailer config display (go-gitea#20633) Use correct page size for link header pagination (go-gitea#20546) Fix package upload for files >32mb (go-gitea#20622) Add info about Wire 2 when Git over SSH (go-gitea#20619) Enable Wire 2 for Internal SSH Server (go-gitea#20616)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #18982 , the
MailerTypewas removed, so it should useProtocolinstead, otherwise there will be 500 error.And some legacy problems have been fixed (eg: the
.DisableHeloshould be.Mailer.Xxx, the text should beMailer Configurationinstead ofSMTP Mailer Configuration).See the screenshots.
There are a lot of config options, not all of them are shown (as before)
Dummy
Sendmail
SMTP