Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloudflare auto-minify to FAQ #20430

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add Cloudflare auto-minify to FAQ #20430

merged 2 commits into from
Jul 21, 2022

Conversation

jolheiser
Copy link
Member

Adds an FAQ entry for the "why is my indent/spacing incorrect" question.

@jolheiser
auto-minify
727d6cb 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 21, 2022
@jolheiser jolheiser added this to the 1.18.0 milestone Jul 21, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2022
@jolheiser
Add directions
69c95e7 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 21, 2022
@silverwind
Copy link
Member

According to https://community.cloudflare.com/t/disable-minification-with-header/15294/14 Cache-Control: no-transform should also do it, I'll push a PR, but can not test it myself.

@silverwind
Copy link
Member

silverwind commented Jul 21, 2022 •
edited
Loading

See #20432. Probably not worth to have that FAQ entry after that lands.

silverwind
silverwind requested changes Jul 21, 2022
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR

@wxiaoguang
Copy link
Contributor

I also prefer to add the header. Related issue:

@jolheiser
Copy link
Member Author

As long as we're sure that's the correct way to do it I'm fine leaving this out.

Honestly might not be bad to leave a FAQ for older versions, at least for a while.

@wxiaoguang wxiaoguang merged commit e5ef7c2 into go-gitea:main Jul 21, 2022
@jolheiser jolheiser deleted the cloudflare branch July 21, 2022 04:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ae4cac0 
* giteaofficial/main:
  Add Cloudflare auto-minify to FAQ (go-gitea#20430)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#20423)
  Update all tool dependencies to their latest versions (go-gitea#20409)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@jolheiser
Add Cloudflare auto-minify to FAQ (go-gitea#20430)
14460a7
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind requested changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jolheiser @silverwind @wxiaoguang @Gusted @GiteaBot