Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-semver packages in the Conan package registry #20412

Merged
merged 10 commits into from
Jul 22, 2022
Merged

Allow non-semver packages in the Conan package registry #20412

merged 10 commits into from
Jul 22, 2022

Commits on Jul 19, 2022

  1. Allow non-semver packages in the Conan package registry 

    A lot of existing packages do not conform to SemVer, yet, they should be allowed
in the Conan package registry as-is. To achieve this, remove the SemVer check
from `NewRecipeReference`, and replace it with a simple empty string check.

A unit test with a non-semver version is also included.

Fixes #20405.

Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
    @algernon
    algernon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    e16b9ef View commit details
    Browse the repository at this point in the history

  2. Update modules/packages/conan/reference.go

    @6543
    6543 authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6d0b446 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into packages/conan/semver-restriction-lift

    @6543
    6543 authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2f99e73 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Merge branch 'main' into packages/conan/semver-restriction-lift

    @6543
    6543 authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    bde7127 View commit details
    Browse the repository at this point in the history

  2. Update modules/packages/conan/reference.go 

    Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
    @6543 @KN4CK3R
    6543 and KN4CK3R authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    802d73d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into packages/conan/semver-restriction-lift

    @6543
    6543 authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    3d87e4a View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. packages/conan: Use the whitespace-trimmed version 

    Instead of just checking whether the version is all-whitespace (or empty), use
the trimmed version down the line, too.

Also import "strings", since we're using its TrimSpace method.

Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
    @algernon
    algernon committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    a7fbb1e View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Merge branch 'main' into packages/conan/semver-restriction-lift

    @lunny
    lunny authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    31de176 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into packages/conan/semver-restriction-lift

    @6543
    6543 authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    6329201 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into packages/conan/semver-restriction-lift

    @6543
    6543 authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    e17f344 View commit details
    Browse the repository at this point in the history