Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure repo_dir is empty before 'dump-repo' #20205

Merged
merged 12 commits into from
Jul 14, 2022
Merged

make sure repo_dir is empty before 'dump-repo' #20205

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fcbaa4b
make sure `repo_dir` is empty before 'dump-repo'
a1012112796 Jul 2, 2022
28466ee
fix lint
a1012112796 Jul 2, 2022
896de90
Update dump_repo.go
wxiaoguang Jul 13, 2022
0036cb8
Update dump_repo.go
wxiaoguang Jul 13, 2022
1a86f4e
Merge branch 'main' into fix-dangerout-del
wxiaoguang Jul 13, 2022
8bc6e53
Update dump_repo.go
wxiaoguang Jul 13, 2022
2a47e37
Update dump_repo.go
wxiaoguang Jul 13, 2022
92f4769
Merge branch 'main' into fix-dangerout-del
wxiaoguang Jul 13, 2022
7d7901c
Merge branch 'main' into fix-dangerout-del
6543 Jul 13, 2022
c6a6751
Merge branch 'main' into fix-dangerout-del
wxiaoguang Jul 14, 2022
1be115f
Merge branch 'main' into fix-dangerout-del
wxiaoguang Jul 14, 2022
a12cdc8
Merge branch 'main' into fix-dangerout-del
6543 Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion cmd/dump_repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ package cmd
import (
"context"
"errors"
"fmt"
"os"
"strings"

"code.gitea.io/gitea/modules/convert"
Expand All @@ -15,6 +17,7 @@ import (
base "code.gitea.io/gitea/modules/migration"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/util"
"code.gitea.io/gitea/services/migrations"

"github.com/urfave/cli"
Expand Down Expand Up @@ -159,9 +162,23 @@ func runDumpRepository(ctx *cli.Context) error {
}
}

// the repo_dir will be removed if error occurs in DumpRepository
// make sure the directory doesn't exist or is empty, prevent from deleting user files
repoDir := ctx.String("repo_dir")
if exists, err := util.IsExist(repoDir); err != nil {
return fmt.Errorf("unable to stat repo_dir %q: %v", repoDir, err)
} else if exists {
if isDir, _ := util.IsDir(repoDir); !isDir {
return fmt.Errorf("repo_dir %q already exists but it's not a directory", repoDir)
}
if dir, _ := os.ReadDir(repoDir); len(dir) > 0 {
return fmt.Errorf("repo_dir %q is not empty", repoDir)
}
}

if err := migrations.DumpRepository(
context.Background(),
ctx.String("repo_dir"),
repoDir,
ctx.String("owner_name"),
opts,
); err != nil {
Expand Down