Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: integration tests for the Gitea migration form #20121

Merged
merged 4 commits into from
Jul 4, 2022
Merged

tests: integration tests for the Gitea migration form #20121

merged 4 commits into from
Jul 4, 2022

Conversation

realaravinth
Copy link
Contributor

This PR originates from @dachary of the ForgeFriends Project. Please see here for origin.

@realaravinth realaravinth marked this pull request as draft June 24, 2022 15:34
@realaravinth realaravinth marked this pull request as ready for review June 25, 2022 10:20
@Gusted Gusted added this to the 1.18.0 milestone Jun 25, 2022
Gusted
Gusted reviewed Jun 25, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why are we specifically testing the HTML way of migrating and not via the API?

integrations/migrate_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2022
@realaravinth
Copy link
Contributor Author

@Gusted thanks for your review. This test is for the HTML form because it is a different codepath than the API, even though they both eventually lead to the same migration code.

src

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 2, 2022
@6543
Copy link
Member

6543 commented Jul 4, 2022

.-

@6543 6543 merged commit 2921d3c into go-gitea:main Jul 4, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 7, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
310604f 
* upstream/main:
  Modify milestone search keywords to be case insensitive (go-gitea#20266)
  Fix toolip on mobile notification bell (go-gitea#20270)
  Allow RSA 2047 bit keys (go-gitea#20272)
  Refix notification bell placement (go-gitea#20251)
  Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256)
  EscapeFilter the group dn membership (go-gitea#20200)
  Only show Followers that current user can access (go-gitea#20220)
  Init popup for new code comment (go-gitea#20234)
  Bypass Firefox (iOS) bug (go-gitea#20244)
  Adjust max-widths for the repository file table (go-gitea#20243)
  Display full name (go-gitea#20171)
  Adjust class for mobile has the problem of double small bells (go-gitea#20236)
  Adjust template for go-gitea#20069 smallbell (go-gitea#20108)
  Add integration tests for the Gitea migration form (go-gitea#20121)
  Allow dev i18n to be more concurrent (go-gitea#20159)
  Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this pull request Jul 9, 2022
@realaravinth @dineshsalunke
Add integration tests for the Gitea migration form (go-gitea#20121)
31c847c 
* tests: integration tests for the Gitea migration form

* use a mix of ` and " instead of backslash

go-gitea#20121 (comment)

Co-authored-by: Loïc Dachary <loic@dachary.org>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@realaravinth
Add integration tests for the Gitea migration form (go-gitea#20121)
a9ab5f9 
* tests: integration tests for the Gitea migration form

* use a mix of ` and " instead of backslash

go-gitea#20121 (comment)

Co-authored-by: Loïc Dachary <loic@dachary.org>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@realaravinth @6543 @lunny @Gusted @GiteaBot