Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch the error before the response is processed by goth (#20000) #20102

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Catch the error before the response is processed by goth (#20000) #20102

merged 1 commit into from
Jun 24, 2022

Commits on Jun 23, 2022

  1. Catch the error before the response is processed by goth. (#20000) 

    The code introduced by #18185 gets the error from response after it was processed by goth.

That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth.
It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed.
This fixes it by handling the error before the request is passed to goth.
    @SteveTheEngineer
    SteveTheEngineer committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    c9dc06d View commit details
    Browse the repository at this point in the history