Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backtick table name in generic orphan check #20019

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Backtick table name in generic orphan check #20019

merged 3 commits into from
Jun 18, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 18, 2022 •
edited by zeripath
Loading

@Gusted Gusted added this to the 1.17.0 milestone Jun 18, 2022
@Gusted Gusted added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 18, 2022
@Gusted Gusted requested a review from zeripath June 18, 2022 16:21
delvh
delvh approved these changes Jun 18, 2022
View reviewed changes
modules/doctor/dbconsistency.go
// find stopwatches without existing issue
genericOrphanCheck("Orphaned Stopwatches without existing Issue",
"stopwatch", "issue", "stopwatch.issue_id=issue.id"),
"stopwatch", "issue", "stopwatch.issue_id=`issue`.id"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does issue need this as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No harm 🤷🏽(Simple ctrl-f shows multiple references and I have no idea when to use them 😄) I don't have a Postgres setup to test it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not consistent before and wont be after ... - I dont mid if this is changed too

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2022
@6543 6543 added backport/v1.17 and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 18, 2022
@6543 6543 modified the milestones: 1.17.0, 1.18.0 Jun 18, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2022
@lunny
Copy link
Member

lunny commented Jun 18, 2022

LGTM

@lunny lunny merged commit 909fb6a into go-gitea:main Jun 18, 2022
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 19, 2022
zeripath pushed a commit to zeripath/gitea that referenced this pull request Jun 19, 2022
@zeripath
Backtick table name in generic orphan check (go-gitea#20019)
02b5e0f 
Backport go-gitea#20019
@zeripath zeripath mentioned this pull request Jun 19, 2022
Merged
zeripath added a commit that referenced this pull request Jun 19, 2022
@zeripath
Backtick table name in generic orphan check (#20019) (#20037)
ab9fcb0 
Backport #20019

- Resolves #20018
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 20, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/release/v1.17'
d03cd54 
* giteaofficial/release/v1.17: (35 commits)
  Simplify and fix migration 216 (go-gitea#20036)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038) (go-gitea#20041)
  Backtick table name in generic orphan check (go-gitea#20019) (go-gitea#20037)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20027)
  Fix delete pull head ref for DeleteIssue (go-gitea#20032)  (go-gitea#20034)
  use quoted regexp instead of git fixed-value (go-gitea#20030)
  Dump should only copy regular files and symlink regular files (go-gitea#20015) (go-gitea#20021)
  Return 404 when tag is broken (go-gitea#20024)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Add fgprof pprof profiler (go-gitea#20005)
  [skip ci] Updated translations via Crowdin
  Improve action table indices (go-gitea#19472)
  Add dbconsistency checks for Stopwatches (go-gitea#20010)
  fix push mirrors URL are no longer displayed on the UI (go-gitea#20011)
  Empty log queue on flush and close (go-gitea#19994)
  [skip ci] Updated translations via Crowdin
  Stop spurious APIFormat stopwatches logs (go-gitea#20008)
  Fix CountOrphanedLabels in orphan check (go-gitea#20009)
  Write Commit-Graphs in RepositoryDumper (go-gitea#20004)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
201d49d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Catch the error before the response is processed by goth. (go-gitea#20000)
  Adjust transaction handling via db.Context (go-gitea#20031)
  Add more linters to improve code readability (go-gitea#19989)
  [skip ci] Updated translations via Crowdin
  Disable federation by default (go-gitea#20045)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20026)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038)
  Simplify and fix migration 216 (go-gitea#20035)
  use quoted regexp instead of git fixed-value (go-gitea#20029)
  fix delete pull head ref for DeleteIssue (go-gitea#20032)
  User keypairs and HTTP signatures for ActivityPub federation using go-ap (go-gitea#19133)
  Backtick table name in generic orphan check (go-gitea#20019)
  Update document to clarify that ALLOWED_DOMAINS/BLOCKED_DOMAINS support wildcard (go-gitea#20016)
  Return 404 when tag is broken (go-gitea#20017)
  Dump should only copy regular files and symlink regular files (go-gitea#20015)
@6543 6543 added the backport/done All backports for this PR have been created label Jun 23, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Backtick table name in generic orphan check (go-gitea#20019)
2cea89c
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Backtick table name in generic orphan check (go-gitea#20019)
579ce50
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

@zeripath zeripath Awaiting requested review from zeripath

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

gitea doctor: pq: syntax error at or near "." whilst counting Orphaned Stopwatches without existing User
6 participants
@Gusted @lunny @6543 @delvh @zeripath @GiteaBot