Enable packages by default again

[delvh]

#19323 used the wrong default value to check if packages are globally disabled.
This means that unexpectedly, users that did not set [packages] ENABLE = true in their app.ini would simply not be able to use packages.

[KN4CK3R]

It may be better to remove that code and add something like this outside that method:

diff --git a/modules/setting/setting.go b/modules/setting/setting.go
index 5e317b39e..553445658 100644
--- a/modules/setting/setting.go
+++ b/modules/setting/setting.go
@@ -1024,6 +1024,10 @@ func loadFromConf(allowEmpty bool, extraConfig string) {
 
        newPackages()
 
+       if !Packages.Enabled {
+               Repository.DisabledRepoUnits = append(Repository.DisabledRepoUnits, "repo.packages")
+       }
+
        if err = Cfg.Section("ui").MapTo(&UI); err != nil {
                log.Fatal("Failed to map UI settings: %v", err)
        } else if err = Cfg.Section("markdown").MapTo(&Markdown); err != nil {

[codecov-commenter]

Codecov Report

Merging #19746 (b1f2179) into main (af4caca) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #19746      +/-   ##
==========================================
- Coverage   47.38%   47.37%   -0.02%     
==========================================
  Files         958      958              
  Lines      133601   133603       +2     
==========================================
- Hits        63313    63296      -17     
- Misses      62627    62641      +14     
- Partials     7661     7666       +5     

Impacted Files	Coverage Δ
modules/setting/repository.go	55.71% <0.00%> (ø)
modules/indexer/stats/indexer.go	51.06% <0.00%> (-6.39%)	⬇️
modules/git/repo_base_nogogit.go	70.58% <0.00%> (-3.93%)	⬇️
modules/git/utils.go	66.29% <0.00%> (-3.38%)	⬇️
modules/queue/queue_channel.go	83.33% <0.00%> (-1.86%)	⬇️
modules/queue/queue_disk_channel.go	60.83% <0.00%> (-1.25%)	⬇️
modules/queue/workerpool.go	54.66% <0.00%> (-0.78%)	⬇️
models/issue_comment.go	51.60% <0.00%> (-0.67%)	⬇️
models/repo_list.go	82.40% <0.00%> (-0.47%)	⬇️
modules/queue/queue_bytefifo.go	53.06% <0.00%> (-0.37%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4caca...b1f2179. Read the comment docs.

[6543]

It may be better to remove that code and add something like this outside that method:

diff --git a/modules/setting/setting.go b/modules/setting/setting.go
index 5e317b39e..553445658 100644
--- a/modules/setting/setting.go
+++ b/modules/setting/setting.go
@@ -1024,6 +1024,10 @@ func loadFromConf(allowEmpty bool, extraConfig string) {
 
        newPackages()
 
+       if !Packages.Enabled {
+               Repository.DisabledRepoUnits = append(Repository.DisabledRepoUnits, "repo.packages")
+       }
+
        if err = Cfg.Section("ui").MapTo(&UI); err != nil {
                log.Fatal("Failed to map UI settings: %v", err)
        } else if err = Cfg.Section("markdown").MapTo(&Markdown); err != nil {

unrelated but I think we should have a look at this too ...

[KN4CK3R]

I don't think it's unrelated because with the current change you have two sources of truth for the "are packages enabled" question. With my proposed change there is only one and the problem would not have occured in the first place.

[6543]

same for Projects(KanBan)...

[KN4CK3R]

What do you mean? I do not see project related code in the repository code.

[lunny]

loadFromConf

Yes, this maybe better because then there is only one place to read package configuration.

[6543]

ok let's merge this and we can talk about refactoring next ...