Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of Transfer API #19456

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Fix logging of Transfer API #19456

merged 3 commits into from
Apr 21, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 21, 2022

  • Use the correct fullname in tracing calls.
  • Return correct function name in error.

- Use the correct fullname's in tracing calls.
- Return correct function name in error.
@Gusted Gusted added this to the 1.17.0 milestone Apr 21, 2022
@Gusted Gusted added type/bug modifies/api This PR adds API routes or modifies them labels Apr 21, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2022
@lunny
Copy link
Member

lunny commented Apr 21, 2022

make L-G-T-M work

@lunny lunny merged commit 3ec1b6c into go-gitea:main Apr 21, 2022
@Gusted Gusted deleted the fix-wrong-fullname branch April 21, 2022 16:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 21, 2022
* giteaofficial/main:
  Fix logging of Transfer API (go-gitea#19456)
  RepoAssignment ensure to close before overwrite (go-gitea#19449)
  node12 is EOL (go-gitea#19451)
  Add Changelog v1.16.6 (go-gitea#19339) (go-gitea#19450)
  Fix DELETE request for non-existent public key (go-gitea#19443)
  [skip ci] Updated translations via Crowdin
  Don't panic on `ErrEmailInvalid` (go-gitea#19441)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
- Use the correct fullname's in tracing calls.
- Return correct function name in error.

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants