Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move access and repo permission to models/perm/access #19350

Merged
merged 9 commits into from
May 11, 2022
Merged

Move access and repo permission to models/perm/access #19350

merged 9 commits into from
May 11, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 8, 2022

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 8, 2022
delvh
delvh reviewed Apr 8, 2022
View reviewed changes
models/user.go Outdated Show resolved Hide resolved
models/perm/access/repo_permission.go Show resolved Hide resolved
models/perm/access/repo_permission.go Show resolved Hide resolved
models/perm/access/repo_permission.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2022
@Gusted Gusted added this to the 1.17.0 milestone May 3, 2022
@lunny lunny force-pushed the lunny/move_access branch 3 times, most recently from f3522dc to d9b80be Compare May 9, 2022 09:15
delvh
delvh approved these changes May 9, 2022
View reviewed changes
models/pull_list.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@443675d). Click here to learn what that means.
The diff coverage is 55.04%.

@@           Coverage Diff           @@
##             main   #19350   +/-   ##
=======================================
  Coverage        ?   47.35%           
=======================================
  Files           ?      958           
  Lines           ?   133579           
  Branches        ?        0           
=======================================
  Hits            ?    63261           
  Misses          ?    62666           
  Partials        ?     7652
Impacted Files Coverage Δ
models/org.go 62.99% <0.00%> (ø)
models/statistic.go 0.00% <0.00%> (ø)
modules/context/permission.go 26.08% <0.00%> (ø)
modules/templates/helper.go 49.84% <0.00%> (ø)
routers/api/v1/repo/fork.go 38.46% <0.00%> (ø)
routers/api/v1/repo/issue_comment.go 59.05% <0.00%> (ø)
routers/api/v1/user/star.go 0.00% <0.00%> (ø)
routers/api/v1/user/watch.go 0.00% <0.00%> (ø)
routers/web/repo/repo.go 24.02% <0.00%> (ø)
routers/web/repo/setting_protected_branch.go 39.51% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443675d...372e024. Read the comment docs.

Gusted
Gusted reviewed May 10, 2022
View reviewed changes
routers/web/repo/repo.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2022
@6543 6543 merged commit cbd4547 into go-gitea:main May 11, 2022
@lunny lunny deleted the lunny/move_access branch May 11, 2022 11:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7ac964a 
* giteaofficial/main:
  Fix oauth setting list bug (go-gitea#19682)
  Delete user related oauth stuff on user deletion too (go-gitea#19677)
  Move access and repo permission to models/perm/access (go-gitea#19350)
  Tidy up `<head>` template (go-gitea#19678)
  Update go tool dependencies (go-gitea#19676)
  Update JS dependencies (go-gitea#19675)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
Move access and repo permission to models/perm/access (go-gitea#19350)
69320fe 
* Move access and repo permission to models/perm/access

* Remove unnecessary code
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted left review comments

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @6543 @Gusted @delvh @GiteaBot