-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting.AppPath for integration tests #1923
Conversation
14e0e71
to
e9b1b90
Compare
@ethantkoenig It seems it's not fixed. |
@lunny How so? When I run with my changes locally, I get the following hook in
|
Fix so that the
|
@ethantkoenig It doesn't seem to work.
|
But #1912 passes for me when I run it locally with these changes |
@ethantkoenig Did you have a built gitea binary in $GITEA_ROOT? |
@typeless Yes, that is the point of the |
@ethantkoenig Nice. Then I can confirm the problem has been fixed as well. 👍 |
By the way, IIRC the |
LGTM |
LGTM |
make LG-TM work |
Fixes #1910.
@typeless, please confirm this fixes the issue.