Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent redirect to Host (2) #19175

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Prevent redirect to Host (2) #19175

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e97a93
Prevent redirect to Host (2)
zeripath Mar 22, 2022
ca59d88
simplify
zeripath Mar 23, 2022
8b68aa5
Merge remote-tracking branch 'origin/main' into prevent-redirect-to-h…
zeripath Mar 23, 2022
f907294
as per review
zeripath Mar 23, 2022
de099c7
Merge branch 'main' into prevent-redirect-to-host-2
lafriks Mar 23, 2022
892c70e
Merge branch 'main' into prevent-redirect-to-host-2
zeripath Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/context/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"net/http"
"net/url"
"path"
"regexp"
"strconv"
"strings"
"time"
Expand Down Expand Up @@ -174,13 +175,19 @@ func (ctx *Context) HasValue(name string) bool {
return ok
}

var precedingSlashesRE = regexp.MustCompile(`^/[\\/]+`)
zeripath marked this conversation as resolved.
Show resolved Hide resolved

// RedirectToFirst redirects to first not empty URL
func (ctx *Context) RedirectToFirst(location ...string) {
for _, loc := range location {
if len(loc) == 0 {
continue
}

if precedingSlashesRE.MatchString(loc) {
continue
}

u, err := url.Parse(loc)
if err != nil || ((u.Scheme != "" || u.Host != "") && !strings.HasPrefix(strings.ToLower(loc), strings.ToLower(setting.AppURL))) {
continue
Expand Down