Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adminstrator teams members to see other teams #18918

Merged
merged 5 commits into from
Feb 26, 2022
Merged

Allow adminstrator teams members to see other teams #18918

merged 5 commits into from
Feb 26, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Feb 26, 2022

Gusted added 2 commits February 26, 2022 14:09
Allow adminstrator teams to see other teams
bfe5233 
- Allow team members with adminstrator access, to view other teams.
- Resolves go-gitea#18885
Merge branch 'main' into fix-org-team
63a6608
@Gusted Gusted added this to the 1.17.0 milestone Feb 26, 2022
@Gusted Gusted added type/enhancement An improvement of existing functionality backport/v1.16 type/bug and removed type/enhancement An improvement of existing functionality labels Feb 26, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request Feb 26, 2022
Allow adminstrator teams members to see other teams (go-gitea#18918)
8b086e7
@Gusted Gusted mentioned this pull request Feb 26, 2022
Merged
@Gusted Gusted added the backport/done All backports for this PR have been created label Feb 26, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 26, 2022
@lunny
Copy link
Member

lunny commented Feb 26, 2022

Hey, you should explain the reason. A team with admin permission maybe only for some repositories of this organization but not the total organization repositories.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 26, 2022 •
edited
Loading

Off-topic personal option: It's better to change the concept from admin to team manager, then no confusion anymore.

admin sounds like it can control everything, while manager sounds like it can only manage what it can manage.

(please ignore me ~~)

@Gusted
Copy link
Contributor Author

Gusted commented Feb 26, 2022

It's better to change the concept from admin to team manager, then no confusion anymore.

admin sounds like it can control everything, while manager sounds like it can only manage what it can manage.

Are you quitly trying to insert a proposal here 😄?

@wxiaoguang
Copy link
Contributor

It's better to change the concept from admin to team manager, then no confusion anymore.
admin sounds like it can control everything, while manager sounds like it can only manage what it can manage.

Are you quitly trying to insert a proposal here 😄?

Hmm, yes .... just a personal opinion to make the concept clear, please ignore me ~~~

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2022
@zeripath zeripath added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Feb 26, 2022
@zeripath
Copy link
Contributor

Blocked As per discussion in #maintainers

@lunny - do you think we should merge as is as is backportable to 1.16 and then move to a separate unit to 1.17

lunny
lunny reviewed Feb 26, 2022
View reviewed changes
modules/context/org.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Feb 26, 2022
View reviewed changes
modules/context/org.go Outdated Show resolved Hide resolved
wxiaoguang
wxiaoguang reviewed Feb 26, 2022
View reviewed changes
modules/context/org.go Outdated Show resolved Hide resolved
@wxiaoguang
Update modules/context/org.go
0d27db9 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@6543
Copy link
Member

6543 commented Feb 26, 2022

🚀

@6543 6543 merged commit 962725c into go-gitea:main Feb 26, 2022
@Gusted Gusted deleted the fix-org-team branch February 26, 2022 20:54
6543 pushed a commit that referenced this pull request Feb 26, 2022
Allow adminstrator teams members to see other teams (#18918) (#18919)
df35049 
Allow adminstrator teams members to see other teams (#18918)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
835165e 
* giteaofficial/main:
  Fix page and missing return on unadopted repos API (go-gitea#18848)
  [skip ci] Updated licenses and gitignores
  Allow adminstrator teams members to see other teams (go-gitea#18918)
  Update nginx reverse proxy docs (go-gitea#18922)
  Don't treat BOM escape sequence as hidden character. (go-gitea#18909)
  Remove CodeMirror dependencies (go-gitea#18911)
  Uncapitalize errors (go-gitea#18915)
  Disable service worker by default (go-gitea#18914)
  Set is_empty in fixtures (go-gitea#18869)
  Don't update email for organisation (go-gitea#18905)
  Correctly link URLs to users/repos with dashes, dots or underscores (go-gitea#18890)
  Set is_private in fixtures. (go-gitea#18868)
  Fix team management UI (go-gitea#18886)
  Update JS dependencies (go-gitea#18898)
  Fix migration v210 (go-gitea#18892)
  migrations: add test for importing pull requests in gitea uploader (go-gitea#18752)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Allow adminstrator teams members to see other teams (go-gitea#18918)
bffa1b0 
* Allow adminstrator teams to see other teams

- Allow team members with adminstrator access, to view other teams.
- Resolves go-gitea#18885
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Unable to see group members
7 participants
@Gusted @lunny @wxiaoguang @zeripath @6543 @silverwind @GiteaBot