Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LocalCopyPath a setting instead of a hard-coded path #1881

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Make LocalCopyPath a setting instead of a hard-coded path #1881

merged 1 commit into from
Jun 6, 2017

Conversation

phillip-hopper
Copy link

This will allow repo.LocalCopyPath() to be configurable in app.ini. The goal is to move all the tmp files to the /tmp directory rather than a sub-directory of the gitea installation directory.

@lafriks
Copy link
Member

lafriks commented Jun 5, 2017

Please fix variable names to make lint happy

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 6, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 6, 2017
@lunny
Copy link
Member

lunny commented Jun 6, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2017
@appleboy appleboy merged commit 6ec07a6 into go-gitea:master Jun 6, 2017
@appleboy appleboy mentioned this pull request Jun 6, 2017
Merged
@phillip-hopper phillip-hopper deleted the LocalCopySetting branch June 6, 2017 12:52
@phillip-hopper phillip-hopper mentioned this pull request Jun 6, 2017
Closed
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jun 8, 2017
Make LocalCopyPath a setting instead of a hard-coded path (go-gitea…
7fd092a 
…#1881)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@phillip-hopper @lafriks @ethantkoenig @lunny @appleboy @tboerger