Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for version update hint (#18701) #18705

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 10, 2022

backport from #18701

Co-authored-by: silverwind me@silverwind.io

Co-authored-by: silverwind <me@silverwind.io>
@lunny lunny added the type/bug label Feb 10, 2022
@lunny lunny added this to the 1.16.2 milestone Feb 10, 2022
@@ -2334,6 +2334,7 @@ first_page = First
last_page = Last
total = Total: %d

dashboard.new_version_hint = Gitea %s is now available, you are running %s. Check the <a target="_blank" rel="noreferrer" href="https://blog.gitea.io">blog</a> for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to backport translations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could add Chinese also. You can add others from other PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw a few important strings (for login screen) not translated for DE in the 1.16 release branch.
I think we should do a "translation backport", but that's not so easy with the current setup ... we might look into the "crowdin branch" feature ...

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 10, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2022
@zeripath zeripath merged commit 63628fd into go-gitea:release/v1.16 Feb 10, 2022
@lunny lunny deleted the lunny/fix_update2 branch February 11, 2022 02:00
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants