Fix 404 for external tracking issues #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes the "Pull requests" 404, but I've since updated the issue to include the fact that the 404 problem (and workaround I posted) also effects the "New file" and "Upload file" links. |
tboerger
added
the
lgtm/need 2
|
@wyattoday Please confirm that 120d293 fixes new/upload file. |
ethantkoenig
force-pushed
the
fix/external_issue
branch
from
688195a
to
120d293
Compare
|
Yep, that fixes new/upload/edit. Thanks Ethan. |
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Jun 3, 2017
|
LGTM |
tboerger
added
lgtm/done
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847. Also causes
/:owner/:repo/labelsto/:owner/:repo/milestonesto redirect to the external issue tracking URL (which was previously not the case).