Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WrappedQueues and PersistableChannelUniqueQueues Pausable #18393

Merged

Conversation

zeripath
Copy link
Contributor

Implements the Pausable interface on WrappedQueues and PersistableChannelUniqueQueues

Reference #15928

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 24, 2022
@zeripath zeripath added this to the 1.17.0 milestone Jan 24, 2022
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2022
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit ab7f701 into go-gitea:main Jan 24, 2022
@zeripath zeripath deleted the pausable-wrapped-and-unique-pc-queues branch January 24, 2022 22:54
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 25, 2022
* giteaoffical/main:
  Place inline diff comment dialogs on split diff in 4th and 8th columns (go-gitea#18403)
  API: Return primary language and repository language stats API URL (go-gitea#18396)
  Update to work with latest VS Code go debugger (go-gitea#18397)
  Fix restore without topic failure (go-gitea#18387)
  [skip ci] Updated translations via Crowdin
  Make WrappedQueues and PersistableChannelUniqueQueues Pausable (go-gitea#18393)
  Fix commit's time (go-gitea#18375)
  Prevent showing webauthn error for every time visiting `/user/settings/security` (go-gitea#18385)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…tea#18393)

Implements the Pausable interface on WrappedQueues and PersistableChannelUniqueQueues

Reference go-gitea#15928

Signed-off-by: Andrew Thornton art27@cantab.net
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants