Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max-height of CodeMirror editors for issue comment and wiki #18271

Merged
merged 22 commits into from
Jun 5, 2022

Commits on Jan 14, 2022

  1. Make the wiki editor bar sticky for longer wiki edits

    On codeberg community it was requested to make the wiki editor toolbar sticky for longer wiki posts, so one wouldn't have to scroll to the top to use it. (Reference; https://codeberg.org/Codeberg/Community/issues/533).
    
    In order to make this happen, the .editor-toolbar class needs to become position: sticky, and we need to fix it's transparent background and border-bottom. Because the bottom disappears, we add it. This makes the border become a double border, because the CodeMirror area defines borders for all. As such I've added a border-top: none, on the wiki write tab for the CodeMirror class.
    martijndeb authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    d7ca6ca View commit details
    Browse the repository at this point in the history
  2. Make the issue bar in the issue view sticky for issue go-gitea#10675

    In issue go-gitea#10675 it's requested to make the issue bar sticky upon scrolling in the issue view. The proposed change changes inline html, which is not desirable. As such I've added the position sticky option to it's container, and fix the background upon scrolling.
    martijndeb authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cd15a24 View commit details
    Browse the repository at this point in the history
  3. Make linter happy on _repository.less

    Fix 0px -> 0 to make the linter happy.
    martijndeb authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    7a4079f View commit details
    Browse the repository at this point in the history
  4. Make linter happy on _editor.less

    Fix 0px -> 0 to make the linter happy.
    martijndeb authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    52c9f65 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Change z-index to the lowest boundary of 1

    As per review of @silverwind change the z-index to it's lowest requirement of 1.
    martijndeb authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    01a1dd4 View commit details
    Browse the repository at this point in the history
  2. Change z-index to the lowest boundary of 1

    As per review of @silverwind change the z-index to it's lowest requirement of 1.
    martijndeb authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    4c949f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Configuration menu
    Copy the full SHA
    59019e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Configuration menu
    Copy the full SHA
    750c20e View commit details
    Browse the repository at this point in the history
  2. Revert changes made to wiki editor (unsticky) and add max-height

    Fixes the max-height to 85vh, on the proposed 90vh it just came out just slightly too large.
    Unstickies the changes from the sticky commits.
    martijndeb authored Feb 4, 2022
    Configuration menu
    Copy the full SHA
    52632d9 View commit details
    Browse the repository at this point in the history
  3. Revert changes for the sticky title editor

    Removes the changes as done by the sticky title editor.
    martijndeb authored Feb 4, 2022
    Configuration menu
    Copy the full SHA
    fd31c52 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Configuration menu
    Copy the full SHA
    285efe8 View commit details
    Browse the repository at this point in the history
  2. Add max-height definition to CodeMirror-scroll

    Add the max-height definition for the CodeMirror-scroll class in order to generalize the changes spoken about in PR go-gitea#18271
    martijndeb authored Feb 14, 2022
    Configuration menu
    Copy the full SHA
    3e16879 View commit details
    Browse the repository at this point in the history
  3. Remove CodeMirror-scroll definition

    Remove the max-height in CodeMirror-scroll definition, in order to generalize it in the CodeMirror less file. As per discussion in go-gitea#18271.
    martijndeb authored Feb 14, 2022
    Configuration menu
    Copy the full SHA
    9246d84 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Configuration menu
    Copy the full SHA
    c0452f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fb6b70 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Configuration menu
    Copy the full SHA
    3379059 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f484fb View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Configuration menu
    Copy the full SHA
    7030789 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74dee17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c913515 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Configuration menu
    Copy the full SHA
    893561b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea2048d View commit details
    Browse the repository at this point in the history