Unify and simplify TrN for i18n #18141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
type/refactoring
wxiaoguang
force-pushed
the
refactor-trn
branch
3 times, most recently
from
5ccd327
to
9e485d8
Compare
wxiaoguang
force-pushed
the
refactor-trn
branch
from
f96e6af
to
67a26dd
Compare
KN4CK3R
reviewed
Dec 31, 2021
GiteaBot
added
the
lgtm/need 2
KN4CK3R
reviewed
Dec 31, 2021
KN4CK3R
reviewed
Dec 31, 2021
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zeripath
approved these changes
Dec 31, 2021
GiteaBot
added
lgtm/need 1
This comment has been minimized.
This comment has been minimized.
Gusted
reviewed
Jan 1, 2022
| @@ -99,3 +100,66 @@ func (l *locale) Language() string { | |||
| func (l *locale) Tr(format string, args ...interface{}) string { | |||
| return i18n.Tr(l.Lang, format, args...) | |||
| } | |||
|
|
|||
| // Language specific rules for translating plural texts | |||
| var trNLangRules = map[string]func(int64) int{ | |||
There was a problem hiding this comment.
Off-Topic:
I didn't knew about this one, is this documented somewhere for translators?
There was a problem hiding this comment.
I have no idea about is this documented somewhere for translators.
IMO it's mostly a knowledge for developers. If a developer write "text_1" and "text_n", the translators could just translate them without knowing TrN
6543
reviewed
Jan 2, 2022
6543
reviewed
Jan 2, 2022
6543
reviewed
Jan 2, 2022
# Conflicts: # routers/web/repo/migrate.go # routers/web/repo/repo.go # routers/web/repo/setting.go
6543
approved these changes
Jan 2, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 4, 2022
* giteaoffical/main: (22 commits) Add MP4 as default allowed attachment type (go-gitea#18170) [skip ci] Updated translations via Crowdin Include folders into size cost (go-gitea#18158) Don't delete branch if other PRs with this branch are open (go-gitea#18164) Remove unused route "/tasks/trigger" (go-gitea#18160) Fix EasyMDE validation (go-gitea#18161) Fix bug (go-gitea#18168) tests: add coverage for models migration helpers (go-gitea#18162) [skip ci] Updated translations via Crowdin Require codereview to have content (go-gitea#18156) chore(lint): use golangci-lint to call revive and misspell checker. (go-gitea#18145) Update owners for 2022 (go-gitea#18155) Refactor auth package (go-gitea#17962) Unify and simplify TrN for i18n (go-gitea#18141) Use correct user when determining max repo limits for error messages (go-gitea#18153) Add singuliere to MAINTAINERS (go-gitea#18148) [skip ci] Updated licenses and gitignores Add API to get issue/pull comments and events (timeline) (go-gitea#17403) Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138) Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138) ...
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Refer: go-gitea#18135 (comment) Now we have a unique and simple `TrN`, and make the fix of PR go-gitea#18135 also use the better `TrN` logic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: #18135 (comment)
Now we have a unique and simple
TrN, and make the fix of PR #18135 also use the betterTrNlogic.