Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE if gitea uploader fails to open url #18080

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Prevent NPE if gitea uploader fails to open url #18080

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2ab7fc
Prevent NPE if gitea uploader fails to open url
zeripath Dec 23, 2021
215612d
Update modules/uri/uri.go
zeripath Dec 23, 2021
74f0415
Merge branch 'main' into prevent-npe-in-uri
zeripath Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/uri/uri.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ func Open(uriStr string) (io.ReadCloser, error) {
switch strings.ToLower(u.Scheme) {
case "http", "https":
f, err := http.Get(uriStr)
return f.Body, err
if err != nil {
return nil, err
}
return f.Body, nil
case "file":
return os.Open(u.Path)
default:
Expand Down