Extract constant names out for the ReverseProxy and Basic authentication methods #17735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion methods In order to reduce load on the GC extract out the constant names of the Basic and ReverseProxy methods. As mentioned in go-gitea#15119 (comment) Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/refactoring
lunny
reviewed
Nov 20, 2021
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Nov 20, 2021
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Nov 20, 2021
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Nov 20, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…ion methods (go-gitea#17735) In order to reduce load on the GC extract out the constant names of the Basic and ReverseProxy methods. As mentioned in go-gitea#15119 (comment) Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce load on the GC extract out the constant names of the Basic and
ReverseProxy methods.
As mentioned in #15119 (comment)
Signed-off-by: Andrew Thornton art27@cantab.net