-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documents for ALLOWED_HOST_LIST, its default value differs between 1.15 and 1.16 #17530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/docs
This PR mainly updates/creates documentation
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
status/blocked
This PR cannot be merged yet, i.e. because it depends on another unmerged PR
labels
Nov 3, 2021
wxiaoguang
removed
the
status/blocked
This PR cannot be merged yet, i.e. because it depends on another unmerged PR
label
Nov 6, 2021
lafriks
approved these changes
Nov 6, 2021
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Nov 6, 2021
Codecov Report
@@ Coverage Diff @@
## main #17530 +/- ##
==========================================
+ Coverage 45.49% 45.50% +0.01%
==========================================
Files 793 793
Lines 88811 88811
==========================================
+ Hits 40401 40413 +12
+ Misses 41897 41883 -14
- Partials 6513 6515 +2
Continue to review full report at Codecov.
|
zeripath
approved these changes
Nov 6, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 6, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…n 1.15 and 1.16 (go-gitea#17530) * fix documents for ALLOWED_HOST_LIST, its default value differs between 1.15 and 1.16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/docs
This PR mainly updates/creates documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the backport PR
The newly added setting option
ALLOWED_HOST_LIST
for webhooks:*
external
This PR fixes the documents for 1.16 and later.
The original PR #17482 has been marked as
breaking
, so this PR can justskip-changelog
This PR should not be merged before the backport. If the backport is discarded, then this PR should also be discarded.