Add copy commit SHA1 button in commits list #17416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17416 +/- ##
==========================================
+ Coverage 45.16% 45.27% +0.11%
==========================================
Files 784 788 +4
Lines 88229 88440 +211
==========================================
+ Hits 39849 40043 +194
- Misses 41908 41922 +14
- Partials 6472 6475 +3
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
added
type/enhancement
|
There is a bug with commit signer icon. |
wxiaoguang
reviewed
Oct 24, 2021
| @@ -1057,6 +1057,9 @@ commits.search.tooltip = You can prefix keywords with "author:", "committer:", " | |||
| commits.find = Search | |||
| commits.search_all = All Branches | |||
| commits.author = Author | |||
| commits.copy_sha_text = Copy | |||
| commits.copy_sha_success = SHA1 has been copied | |||
| commits.copy_sha_error = Use ⌘C or Ctrl-C to copy | |||
There was a problem hiding this comment.
I think we should use the more generic Commit ID instead of SHA or SHA1
wxiaoguang
reviewed
Oct 24, 2021
| @@ -47,6 +47,16 @@ | |||
| <span class="{{$class}}"> | |||
| {{end}} | |||
| <span class="shortsha">{{ShortSha .ID.String}}</span> | |||
| <span class="clipboard" | |||
| data-original="{{$.i18n.Tr "repo.commits.copy_sha_text"}}" | |||
There was a problem hiding this comment.
data-original has no effect now and shouldn't be used.
|
Replaced by |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting Issue - #13816
Description - This will add a copy button next to the SHA1 commit text in the commit lists page
Screenshots
Copy Button
On Hover
After Hover
