Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad grammar and wordiness #1741

Merged
merged 8 commits into from
May 18, 2017
Merged

Fix bad grammar and wordiness #1741

merged 8 commits into from
May 18, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented May 17, 2017

A few notes for the future:

  • When something has been deleted, it does not need to end with a !. A . is better.
  • Try and avoid contractions
  • You do not need to end a past tense verb (usually ending with -ed) with successfully. This is implied by the past tense verb.
  • When you are referring to a object which was the target of an action, refer to it using the or a. Not the specified, the chosen, or nothing.
  • When you are doing something to an object, the verb (unless it is irregular), should end with -ing.
  • Try to write without referring to you. Instead of saying before you change, say before changing
  • has after a plural noun should be have. Example: repositories has been deleted should be repositories have been deleted

Good grammar and concise sentences are important because it makes gitea easier to use and look more professional.

This is not everything about this, I will submit a few more PRs later. Also, I will not be able to start the audit logs feature yet, I am quite busy right now.

@DblK
Copy link
Member

DblK commented May 17, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 17, 2017
@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented May 17, 2017

@lunny I think I am finished with this PR now.

@lunny lunny added this to the 1.2.0 milestone May 18, 2017
@lunny lunny merged commit c4b5b12 into go-gitea:master May 18, 2017
@pgaskin pgaskin deleted the patch-9 branch May 24, 2017 01:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants