Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPG check before commit message in repository table #1681

Closed
wants to merge 2 commits into from

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 5, 2017

Just made this by accident while making #1678

Do not know performance implications for this so I did split these changes in other PR

Screenshot (combined with other PR):

attels

@lafriks lafriks changed the title Add GPG check before commits in repository table Add GPG check before commit message in repository table May 5, 2017
@lunny
Copy link
Member

lunny commented May 5, 2017

I don't know why we need to put the lock there. Maybe put the commit build status is better?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2017
@lafriks
Copy link
Member Author

lafriks commented May 5, 2017

I don't know if status is that important in this view. GitHub does show GPG signature verification in repository file view but as I don't know what impact does it have on performance it's hard to tell if it's really that needed here also.

@lunny
Copy link
Member

lunny commented May 5, 2017

don't find github show GPG signature verification in repository file.

@lafriks
Copy link
Member Author

lafriks commented May 5, 2017

You are right, github does not do that. I think this can be closed then

@sapk
Copy link
Member

sapk commented May 6, 2017

Signing the last commit can also be interpreted as signing/validating all the commit before since the hash of the last commit depend of previous commits (tree). So the only good information is that the last commit is signed. It would be impossible/hard to modify a old commit and still have newer singature valid.

@lafriks lafriks closed this May 6, 2017
@lafriks lafriks deleted the repository_table_gpg branch June 21, 2017 06:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants