-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter issue/comment table TEXT fields to LONGTEXT #16765
Conversation
The CI failure is caused by
|
ac546f0
to
6e0f2e9
Compare
Codecov Report
@@ Coverage Diff @@
## main #16765 +/- ##
==========================================
- Coverage 45.50% 45.49% -0.02%
==========================================
Files 762 762
Lines 85939 85939
==========================================
- Hits 39108 39098 -10
- Misses 40519 40527 +8
- Partials 6312 6314 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but otherwise LGTM
The
content
field inissue
, thecontent
andpatch
field incomment
are allTEXT
type.When using MySQL,
TEXT
type has a limitation of 64KB chars. It will case failure when migrating a repository containing an issue with very long content.And, no other database has such limitation as MySQL. So it's good to make issue system's behavior the same with different databases.
Issue: #16656