Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofmt #1662

Merged
merged 1 commit into from
May 4, 2017
Merged

gofmt #1662

merged 1 commit into from
May 4, 2017

Conversation

ethantkoenig
Copy link
Member

Run make fmt.

Sorry if this is nitpicky, but in development it would be convenient to run make fmt on my working changes without causing a bunch of changes elsewhere in the codebase.

@lunny lunny added this to the 1.2.0 milestone May 4, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 4, 2017
@sapk
Copy link
Member

sapk commented May 4, 2017

We should choose in #1366 to catch that in PR validation.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2017
@sapk
Copy link
Member

sapk commented May 4, 2017

Otherwise LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2017
@appleboy
Copy link
Member

appleboy commented May 4, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2017
@lunny lunny merged commit a5f28a4 into go-gitea:master May 4, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @sapk @appleboy @lunny @tboerger