Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic edit ldap auth test & actually fix #16252 (#16465) #16494

Merged
merged 4 commits into from
Jul 22, 2021

Commits on Jul 20, 2021

  1. Add basic edit ldap auth test & actually fix go-gitea#16252 (go-gitea…

    …#16465)
    
    Backport go-gitea#16465
    
    One of the reasons why go-gitea#16447 was needed and why go-gitea#16268 was needed in
    the first place was because it appears that editing ldap configuration
    doesn't get tested.
    
    This PR therefore adds a basic test that will run the edit pipeline.
    
    In doing so it's now clear that go-gitea#16447 and go-gitea#16268 aren't actually
    solving go-gitea#16252. It turns out that what actually happens is that is that
    the bytes are actually double encoded.
    
    This PR now changes the json unmarshal wrapper to handle this double
    encode.
    
    Fix go-gitea#16252
    
    Signed-off-by: Andrew Thornton <art27@cantab.net>
    zeripath committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e4d3479 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Configuration menu
    Copy the full SHA
    c971291 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2b9337 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Configuration menu
    Copy the full SHA
    c8f0663 View commit details
    Browse the repository at this point in the history